This repository has been archived by the owner on Oct 18, 2021. It is now read-only.
add more check for config file & add test #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicole00
commented
Jul 19, 2021
| @@ -237,4 +241,57 @@ class ConfigsSuite { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
split multi test cases；
add @test(expected = IllegalArgumentException.class)
HarrisChu
reviewed
Jul 19, 2021
| // wrong graph address | ||
| val wrongGraphAddress = List("127.0.0.1:9669,127.0.0.1:9670") | ||
| try { | ||
| DataBaseConfigEntry(wrongGraphAddress, space, metaAddress) |
There was a problem hiding this comment.
could use ExpectedException rule in the test method
HarrisChu
approved these changes
Jul 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the pre-check makes the config error more understandable